-
-
Notifications
You must be signed in to change notification settings - Fork 616
Add Google Material Symbols #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It currently fails to compile because: I guess the 4000-ish lines of code in a single Do you have any advice on how to fix this? We could have separate classes somehow, perhaps split into 4 sub-ranges by alphabet? |
|
@Philipp91 thank you very much. And yes, splitting it into multiple enums is required. See for example: Line 2735 in 9109ca1
|
|
Also I'd really appreciate if you could follow the naming scheme already established for the icon set from google: |
|
The outlined one already exists: |
No that's something else. Those are the Material Icons (of which there are around 1400), whereas what I'm adding are the Material Symbols (of which there are around 4000 apparently). Both of them are published in the same GitHub repo:
That's also why I broke with the naming scheme. But if you prefer, I can prefix |
|
Ah! thanks for the clarification @Philipp91 |
4bc39d8 to
2947b50
Compare
Thank you! I've now implemented it like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for Google Material Symbols icon font library to the Android-Iconics framework. Material Symbols is Google's newest icon set that consolidates over 2,500 glyphs into a single variable font file.
Key Changes
- Added new
material-symbols-typeface-outlined-librarymodule with complete implementation - Integrated the library into the build system and app dependencies
- Updated documentation to list Material Symbols as an available font
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle |
Added module inclusion for material-symbols-typeface-outlined-library |
release.sh |
Added publish command comment for material symbols |
OutlinedMaterialSymbols.kt |
Main typeface implementation with 4,191 icon definitions split across two enums |
Initializer.kt |
Auto-initialization via AndroidX Startup |
AndroidManifest.xml |
Startup provider configuration for automatic font registration |
gradle.properties |
Maven artifact configuration |
download.sh |
Shell script to download font and generate icon definitions |
consumer-proguard-rules.pro |
ProGuard rules to preserve the typeface class |
build.gradle |
Module build configuration |
app/build.gradle |
Added dependency on the new library |
README.md |
Documentation update listing Material Symbols |
font_description.xml |
Library metadata for AboutLibraries integration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
thank you so much @Philipp91 it was released here 20 mins ago: https://repo1.maven.org/maven2/com/mikepenz/material-symbols-typeface-outlined/0.39.3.0/ |
|
Thank you for taking care of it! Should there be a |
|
That's 6 years ago. Everything is in kotlin now I might have to release everything as I had to upgrade quite a few things to be able to publish again |
|
If you add the core and typeface dependency. Do you still see the same? |
|
I believe that's what I did (or did you mean I should add nothing else?). |
|
I suspect the typeface library is built against In other words, after bumping |
|
That's probably it. Will do a full rerelease of everything |
No description provided.